[testing ci] add tests for unicode tarballs, fix utf-8 on macOS CI#20060
[testing ci] add tests for unicode tarballs, fix utf-8 on macOS CI#20060strega-nil wants to merge 3 commits intomicrosoft:masterfrom
Conversation
see the errors in microsoft#19963
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
I think this belongs as an e2e test rather than here? |
|
@BillyONeal it's testing |
Kinda related to #19034 where I made the same comment. As far as I know this is testing scripts/cmake meaning it logically belongs in the tool repo. |
|
@BillyONeal At that point, we should probably pull out the test_ports directory, but until then the scripts still live in |
NancyLi1013
added
category:scripts-audit
category:infrastructure
Note the table I posted in #19034 (comment). IMO key question is what triggers the test. If scripts are moved out of |
strega-nil-ms
changed the title
| clean: resources | ||
| timeoutInMinutes: 1440 # 1 day | ||
| variables: | ||
| - name: LC_ALL |
There was a problem hiding this comment.
It seems like maybe vcpkg itself should be setting this rather than hiding it in CI? It would be in keeping with other environment variable handling we do....
There was a problem hiding this comment.
I don't know how to set this variable in general; I don't even know if it's possible. Perhaps we could do some locale parsing; however, for CI, it makes sense that we set it to en_US.UTF-8.
|
I think the correct fix here is to have vcpkg set the locale by testing a few common ones like:
and choosing the first matching one. Notably, this change plus #19963 will break existing macos customers, most of whom aren't passing LC_ALL like this. |
|
So, should we wait for the next vcpkg release? |
It looks like the current tool should have the fix:
|
|
Closing in favor of the next tool |
6 participants
see the errors in #19963